Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site-kit): update logger cron to hourly interval #3485

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR updates the site kit logger cron job from daily to hourly.

See https://a8c.slack.com/archives/C06G94HSV5G/p1729283797459139?thread_ts=1729283190.506369&cid=C06G94HSV5G for more details.

How to test the changes in this Pull Request:

  1. Tunnel your local site so your URL is public and connect Google Site Kit
  2. Access admin via the local url (not the public one) to trigger a Site Kit disconnect.
  3. Using something like WP-Crontrol, verify a new hourly newspack_googlesitekit_disconnection_logger cron event is present.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle requested a review from a team as a code owner October 18, 2024 21:06
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant